Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing factories from base Connection class. #1113

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Removing factories from base Connection class. #1113

merged 1 commit into from
Aug 31, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 28, 2015

These are no longer needed since the factories are on all clients.

Literally 100% red (0 additions). I love it!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2015
@jgeewax
Copy link
Contributor

jgeewax commented Aug 28, 2015

Sorry, just not sure I follow. Wouldn't we prefer to put the single method on the base class and let the others inherit those methods?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 29, 2015

Connection used to need these factories because users directly created them. Now that we have Clients this is unnecessary and so both the base connection and client class have these factories

These are no longer needed since the factories are on all clients

@tseaver
Copy link
Contributor

tseaver commented Aug 31, 2015

Hmm, needs a rebase?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 31, 2015

On it.

@dhermes
Removing factories from base Connection class.
8e86218 
These are no longer needed since the factories are on
all clients.
@dhermes dhermes force-pushed the remove-connection-factories branch from 43edb55 to 8e86218 Compare August 31, 2015 19:45
@dhermes
Copy link
Contributor Author

dhermes commented Aug 31, 2015

@tseaver PTAL. Rebased.

@tseaver
Copy link
Contributor

tseaver commented Aug 31, 2015

LGTM

dhermes added a commit that referenced this pull request Aug 31, 2015
@dhermes
Merge pull request #1113 from dhermes/remove-connection-factories
dd35f25 
Removing factories from base Connection class.
@dhermes dhermes merged commit dd35f25 into googleapis:master Aug 31, 2015
@dhermes dhermes deleted the remove-connection-factories branch August 31, 2015 20:08
@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @jgeewax @tseaver @googlebot