Removing use of pytz module / implementing our own UTC. #1044
Conversation
googlebot
added
the
cla: yes
| NOW = datetime.datetime(2015, 7, 28, 16, 34, 47, tzinfo=eastern) | ||
| EPOCH = datetime.datetime(1970, 1, 1, tzinfo=pytz.utc) | ||
|
|
||
| class CET(_UTC): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
No problem with this one overall. I wonder if our local |
|
@tseaver RE: default to using Code reviews are so useful 😄 I totally overlooked that and it's totally the right way to go. |
|
I figured that dropping |
|
Yeah for sure. |
dhermes
force-pushed
the
remove-pytz-dependency
branch
from
790e798 to
b8bce16
Compare
|
@tseaver I re-pushed the initial commit. Sorry I finished it awhile ago but forgot to push. Wanted to actually test the case that |
|
We could add a |
|
What is that? |
|
Oops, I inverted it in my mind: we could add a stanza that tests it w/ [testenv:py27_w_extras]
deps =
{[testenv]deps}
pytz |
|
Can we punt on it for this PR and |
|
Sure. The only thing I see which might be gating is we have no explicit test coverage for the |
|
I added it to |
|
LGTM |
Removing use of pytz module / implementing our own UTC.
| from gcloud import _helpers as MUT | ||
|
|
||
| klass = self._getTargetClass() | ||
| self.assertTrue(isinstance(MUT.UTC, klass)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was inspired by #1009.
Our methods for signing strings with credentials / crypto will likely be moved into
oauth2client, so this is a pre-emptive move to avoid havingpytzas a dependency foroauth2client.As an added benefit, we avoid having
pytzas a dependency, which helps for people wanting to usegcloud-pythonon App Engine./cc @nathanielmanistaatgoogle