-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bigquery): fix inserting missing repeated fields #10196
Conversation
The failing snippets test is unrelated, #10195 will fix it, |
The unit tests failure will be fixed in #10222. |
Weird, a couple of PermissionDenied errors in system tests. Re-running the jobs. Update: I cannot reproduce this locally, neither on the PR branch, nor on on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM
Fixes #9602.
This PR fixes the issue when inserting rows with missing REPEATED fields. Omitting a REPEATED field from the request does not result in an error anymore.
How to test
Best to run the ready-made script from one of the issue comments.
MIND:
Omitting
None
values only happens when the code needs to convert the data to JSON by itself, i.e. ininsert_rows()
. The following thus still fails wheninsert_rows_json()
is used:If this inconsistency is not desired, we need to sync the logic in these two methods.
PR checklist