Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resourcemanager): update test assertion and core version pin #10095

Merged
merged 2 commits into from
Jan 10, 2020
Merged

fix(resourcemanager): update test assertion and core version pin #10095

merged 2 commits into from
Jan 10, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 10, 2020

Towards #10088.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
Adjust request params assertion in test (timeout)
ac11399
@plamut
Bump pin for core dependency
c27c0c4 
This is to assure that Connection object from core supports
timeouts.
@plamut plamut added the api: cloudresourcemanager Issues related to the Resource Manager API. label Jan 10, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@plamut plamut merged commit 755eb36 into googleapis:master Jan 10, 2020
@plamut plamut deleted the fix-tests-resourcemanager branch January 10, 2020 17:57
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Jun 4, 2023
@plamut
fix(resourcemanager): update test assertion and core version pin (#10095
f635c8a 
)

* Adjust request params assertion in test (timeout)

* Bump pin for core dependency

This is to assure that Connection object from core supports
timeouts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: cloudresourcemanager Issues related to the Resource Manager API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plamut @busunkim96 @googlebot