Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Generate Admin V1 Client. #8664

Closed
BenWhitehead opened this issue Jul 12, 2019 · 3 comments · Fixed by #8667
Closed

Firestore: Generate Admin V1 Client. #8664

BenWhitehead opened this issue Jul 12, 2019 · 3 comments · Fixed by #8667
Assignees
Labels
api: firestore Issues related to the Firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@BenWhitehead
Copy link
Contributor

Adding the Firestore Admin API Client will allow programmatic management of indexes, and export/import operations.

Feel free to ping me if any updates are needed for the artman file.

b/129353554

@BenWhitehead BenWhitehead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: firestore Issues related to the Firestore API. labels Jul 12, 2019
@tseaver tseaver changed the title Firestore: Add Firestore Admin API V1 Client to google-cloud-firestore package Firestore: Generate Admin V1 Client. Jul 12, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2019

Supersedes #6344.

@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2019

@BenWhitehead One question: is there any requirement to tweak the admin client surface, or is this a pure autogen client?

@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2019

@BenWhitehead I do need a change in googleapis: please see googleapis/googleapis#566.

Rationale: the gapic-genrator is dumping the protoc-generated Python files in ~/.cache/synthtool/googleapis/artman-genfiles/python/firestore-admin-v1/google/cloud/firestore_v1, rather than the expected .cache/synthtool/googleapis/artman-genfiles/python/firestore-admin-v1/google/cloud/firestore_admin_v1/, where it copies the actual .proto files.

For comparison, see: https://github.com/googleapis/googleapis/blob/47bd0c2ba33c28dd624a65dad382e02bb61d1618/google/bigtable/admin/v2/bigtableadmin_gapic.yaml#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants