-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version the docs #472
Comments
Thanks for the suggestion @ptone, we've had some other great docs feedback lately. Hopefully we can reach a more stable API soon and versions will become more meaningful. I think first and foremost, not building docs from HEAD should be done. |
My bad, I left in the version string without providing a version history. I think it's fine to build from master, as long as it's properly built in a |
+1 for this. I'm starting reading source code at the specific commit / tag in order to know what's supported in that version. |
+1 for this. The coding example under Getting Started for Storage doesn't work because the signature for get_buckets() has changed. This is really confusing because the docs say |
Something like http://googlecloudplatform.github.io/gcloud-node/#/docs/history is preferred so hopefully we can borrow from @silvolu you mentioned you had started this, do you have any half-finished work to go from? |
@dhermes I mentioned I would start this, but then I got side tracked, so nope, I got nothing :/ |
@rstuart85 in the short term https://github.com/GoogleCloudPlatform/gcloud-python/releases/tag/v0.4.0 means the docs reflect the latest version on PyPI. I'm hoping to resolve this issue soon-ish. |
Starting on this right now. |
@dhermes great news! |
Release pushed but new docs didn't build: "Not in master on a non-pull request. Doing nothing." Me thinks |
Fixes googleapis#472. (This is the last piece needed after googleapis#625 and googleapis#662)
* Generate google-cloud-bigquery-storage library using synthtool. (#472) * Add simple system test for BigQuery Storage API (#473) * Add simple system test for BigQuery Storage API For the system tests to run correctly, an unreleased version of api_core is required. Updates the setup.py file to indicate the minimum version. * Remove mock dependency and unnecessary imports. * Use -e for local deps. * Add manual client for BigQuery Storage (#474) * Add manual client for BigQuery Storage. The manual client adds a default project, which is used by the wrapped create_read_session to make the project parameter optional. A future purpose of the manual client is to override the read_rows method to return an iterator that can reconnect with the correct offset, much like Spanner's StreamedResultSet class. This work is not yet complete. I'd like feedback on the approach for the manual client first. * Use same client name as wrapped gapic class. * Use subclass for BigQueryStorageClient Also, change create_read_session project argument back to 'parent' to better match the super class. * Add unit tests. * Remove default project from manual client. * Use project_id fixture in system tests. * Regenerate google-cloud-bigquery-storage (#475) * Regenerate google-cloud-bigquery-storage * Re-synthed * Handwritten reader to reconnect on ReadRows streams (#477) * WIP: reader to reconnect on ReadRows streams * Add method to copy a StreamPosition. * Add unit tests for hand-written reader module. * Add docs for new hand-written module. * Add fastavro to root intersphinx * Add ServiceUnavailable to list of resumable exceptions. Pull in .coveragerc file from upstream google-cloud-python.
* Generate google-cloud-bigquery-storage library using synthtool. (googleapis#472) * Add simple system test for BigQuery Storage API (googleapis#473) * Add simple system test for BigQuery Storage API For the system tests to run correctly, an unreleased version of api_core is required. Updates the setup.py file to indicate the minimum version. * Remove mock dependency and unnecessary imports. * Use -e for local deps. * Add manual client for BigQuery Storage (googleapis#474) * Add manual client for BigQuery Storage. The manual client adds a default project, which is used by the wrapped create_read_session to make the project parameter optional. A future purpose of the manual client is to override the read_rows method to return an iterator that can reconnect with the correct offset, much like Spanner's StreamedResultSet class. This work is not yet complete. I'd like feedback on the approach for the manual client first. * Use same client name as wrapped gapic class. * Use subclass for BigQueryStorageClient Also, change create_read_session project argument back to 'parent' to better match the super class. * Add unit tests. * Remove default project from manual client. * Use project_id fixture in system tests. * Regenerate google-cloud-bigquery-storage (googleapis#475) * Regenerate google-cloud-bigquery-storage * Re-synthed * Handwritten reader to reconnect on ReadRows streams (googleapis#477) * WIP: reader to reconnect on ReadRows streams * Add method to copy a StreamPosition. * Add unit tests for hand-written reader module. * Add docs for new hand-written module. * Add fastavro to root intersphinx * Add ServiceUnavailable to list of resumable exceptions. Pull in .coveragerc file from upstream google-cloud-python.
…cp/templates/python_library/.kokoro (#472) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…cp/templates/python_library/.kokoro (#472) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…cp/templates/python_library/.kokoro (#472) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…cp/templates/python_library/.kokoro (#472) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
updating typo from dialogvlow_v2 to dialogflow_v2
Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…ic enums (#472) * feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add rest to tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
…cp/templates/python_library/.kokoro (#472) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
The docs at http://googlecloudplatform.github.io/gcloud-python/datastore-api.html document the current API at git head - and include a version tag of 0.3.0
This matches the current released version on pypi (that does not have the recent change for implicit credentials)
Please consider using something like readthedocs and provide versioned docs - so that what users find actually matches what they are likely to install :)
Or at least mark the version in master as -dev with a warning in docs, and tag to stable version in a branch.
The text was updated successfully, but these errors were encountered: