Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version the docs #472

Closed
ptone opened this issue Dec 29, 2014 · 10 comments · Fixed by #625 or #674
Closed

Version the docs #472

ptone opened this issue Dec 29, 2014 · 10 comments · Fixed by #625 or #674
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@ptone
Copy link
Contributor

ptone commented Dec 29, 2014

The docs at http://googlecloudplatform.github.io/gcloud-python/datastore-api.html document the current API at git head - and include a version tag of 0.3.0

This matches the current released version on pypi (that does not have the recent change for implicit credentials)

Please consider using something like readthedocs and provide versioned docs - so that what users find actually matches what they are likely to install :)

Or at least mark the version in master as -dev with a warning in docs, and tag to stable version in a branch.

@dhermes
Copy link
Contributor

dhermes commented Dec 29, 2014

Thanks for the suggestion @ptone, we've had some other great docs feedback lately. Hopefully we can reach a more stable API soon and versions will become more meaningful.

I think first and foremost, not building docs from HEAD should be done.

@silvolu
Copy link
Contributor

silvolu commented Dec 30, 2014

My bad, I left in the version string without providing a version history. I think it's fine to build from master, as long as it's properly built in a -dev version as suggested by @ptone (and that is what we do with gcloud-node where we have a master version).
I'll fix it.

@yjkogan
Copy link

yjkogan commented Jan 30, 2015

+1 for this. I'm starting reading source code at the specific commit / tag in order to know what's supported in that version.

@jgeewax jgeewax modified the milestone: Core Stable Jan 30, 2015
@rstuart85
Copy link

+1 for this. The coding example under Getting Started for Storage doesn't work because the signature for get_buckets() has changed. This is really confusing because the docs say 0.3.0 which matches the version on PyPi as already pointed out. The only way to figure it out is the read the source code which probably isn't ideal.

@dhermes
Copy link
Contributor

dhermes commented Feb 6, 2015

Something like http://googlecloudplatform.github.io/gcloud-node/#/docs/history is preferred so hopefully we can borrow from gcloud-node

@silvolu you mentioned you had started this, do you have any half-finished work to go from?

@silvolu
Copy link
Contributor

silvolu commented Feb 6, 2015

@dhermes I mentioned I would start this, but then I got side tracked, so nope, I got nothing :/

@dhermes
Copy link
Contributor

dhermes commented Feb 7, 2015

@rstuart85 in the short term https://github.com/GoogleCloudPlatform/gcloud-python/releases/tag/v0.4.0 means the docs reflect the latest version on PyPI. I'm hoping to resolve this issue soon-ish.

@dhermes dhermes assigned dhermes and unassigned silvolu Feb 12, 2015
@dhermes
Copy link
Contributor

dhermes commented Feb 12, 2015

Starting on this right now.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Feb 12, 2015
@rstuart85
Copy link

@dhermes great news!

@dhermes
Copy link
Contributor

dhermes commented Feb 14, 2015

Release pushed but new docs didn't build:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/50716542

"Not in master on a non-pull request. Doing nothing."

Me thinks "${TRAVIS_BRANCH}" == "master" fails when pushing a tag. I'll have to play around and address this.

@dhermes dhermes reopened this Feb 14, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Feb 18, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Feb 18, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Feb 20, 2015
tswast added a commit to tswast/google-cloud-python that referenced this issue Nov 29, 2018
tswast added a commit that referenced this issue Nov 29, 2018
* Generate google-cloud-bigquery-storage library using synthtool. (#472)

* Add simple system test for BigQuery Storage API (#473)

* Add simple system test for BigQuery Storage API

For the system tests to run correctly, an unreleased version of api_core
is required. Updates the setup.py file to indicate the minimum version.

* Remove mock dependency and unnecessary imports.

* Use -e for local deps.

* Add manual client for BigQuery Storage (#474)

* Add manual client for BigQuery Storage.

The manual client adds a default project, which is used by the wrapped
create_read_session to make the project parameter optional.

A future purpose of the manual client is to override the read_rows
method to return an iterator that can reconnect with the correct offset,
much like Spanner's StreamedResultSet class. This work is not yet
complete.  I'd like feedback on the approach for the manual client
first.

* Use same client name as wrapped gapic class.

* Use subclass for BigQueryStorageClient

Also, change create_read_session project argument back to 'parent' to
better match the super class.

* Add unit tests.

* Remove default project from manual client.

* Use project_id fixture in system tests.

* Regenerate google-cloud-bigquery-storage (#475)

* Regenerate google-cloud-bigquery-storage

* Re-synthed

* Handwritten reader to reconnect on ReadRows streams (#477)

* WIP: reader to reconnect on ReadRows streams

* Add method to copy a StreamPosition.

* Add unit tests for hand-written reader module.

* Add docs for new hand-written module.

* Add fastavro to root intersphinx

* Add ServiceUnavailable to list of resumable exceptions.

Pull in .coveragerc file from upstream google-cloud-python.
erikwebb pushed a commit to erikwebb/google-cloud-python that referenced this issue Dec 3, 2018
* Generate google-cloud-bigquery-storage library using synthtool. (googleapis#472)

* Add simple system test for BigQuery Storage API (googleapis#473)

* Add simple system test for BigQuery Storage API

For the system tests to run correctly, an unreleased version of api_core
is required. Updates the setup.py file to indicate the minimum version.

* Remove mock dependency and unnecessary imports.

* Use -e for local deps.

* Add manual client for BigQuery Storage (googleapis#474)

* Add manual client for BigQuery Storage.

The manual client adds a default project, which is used by the wrapped
create_read_session to make the project parameter optional.

A future purpose of the manual client is to override the read_rows
method to return an iterator that can reconnect with the correct offset,
much like Spanner's StreamedResultSet class. This work is not yet
complete.  I'd like feedback on the approach for the manual client
first.

* Use same client name as wrapped gapic class.

* Use subclass for BigQueryStorageClient

Also, change create_read_session project argument back to 'parent' to
better match the super class.

* Add unit tests.

* Remove default project from manual client.

* Use project_id fixture in system tests.

* Regenerate google-cloud-bigquery-storage (googleapis#475)

* Regenerate google-cloud-bigquery-storage

* Re-synthed

* Handwritten reader to reconnect on ReadRows streams (googleapis#477)

* WIP: reader to reconnect on ReadRows streams

* Add method to copy a StreamPosition.

* Add unit tests for hand-written reader module.

* Add docs for new hand-written module.

* Add fastavro to root intersphinx

* Add ServiceUnavailable to list of resumable exceptions.

Pull in .coveragerc file from upstream google-cloud-python.
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
atulep pushed a commit that referenced this issue Apr 3, 2023
…cp/templates/python_library/.kokoro (#472)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
…cp/templates/python_library/.kokoro (#472)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
…cp/templates/python_library/.kokoro (#472)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this issue Apr 18, 2023
…cp/templates/python_library/.kokoro (#472)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this issue Jun 4, 2023
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Aug 15, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
updating typo from dialogvlow_v2 to dialogflow_v2
parthea pushed a commit that referenced this issue Sep 22, 2023
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea pushed a commit that referenced this issue Sep 22, 2023
Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Oct 21, 2023
…ic enums (#472)

* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add rest to tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Oct 22, 2023
…cp/templates/python_library/.kokoro (#472)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
7 participants