Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity.reload does not work #464

Closed
dhermes opened this issue Dec 23, 2014 · 0 comments · Fixed by #480
Closed

Entity.reload does not work #464

dhermes opened this issue Dec 23, 2014 · 0 comments · Fixed by #480
Assignees
@dhermes
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@dhermes
Copy link
Contributor

dhermes commented Dec 23, 2014

We should make sure to fix the tests as well as the code:

        key = self._must_key
        dataset = self._must_dataset
        entity = dataset.get_entity(key.to_protobuf())

(the key should be re-loaded, not the key protobuf).

Example failure:

>>> entity.reload()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "gcloud/datastore/entity.py", line 215, in reload
    entity = dataset.get_entity(key.to_protobuf())
  File "gcloud/datastore/dataset.py", line 139, in get_entity
    key = Key.from_path(*key_or_path)
TypeError: from_path() argument after * must be a sequence, not Key
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 23, 2014
@dhermes dhermes self-assigned this Jan 2, 2015
@dhermes dhermes mentioned this issue Jan 2, 2015
Merged
@jgeewax jgeewax modified the milestone: Datastore Stable Jan 30, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
atulep pushed a commit that referenced this issue Apr 6, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#464)
31f77bc
atulep pushed a commit that referenced this issue Apr 6, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#464)
1517cec
atulep pushed a commit that referenced this issue Apr 18, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#464)
d1c1e1e
parthea pushed a commit that referenced this issue Jun 4, 2023
@release-please
chore(main): release 2.13.0 (#464)
3015e2d 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jul 6, 2023
@dpebot @busunkim96
Auto-update dependencies. [(#464)](GoogleCloudPlatform/python-docs-sa…
d6594b6 
…mples#464)
parthea pushed a commit that referenced this issue Aug 15, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow-cx to v1.13.4 (#…
fa411fc 
…464)
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@gcf-owl-bot
feat(v2): add conversation process config (#464)
a108e23 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 423223164

Source-Link: googleapis/googleapis@356f0c0

Source-Link: googleapis/googleapis-gen@72fe020
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJmZTAyMDJmNGUzZTkxZmU3YTdhNTJjYTI0ODE3NzI2MWMyY2MzZiJ9

feat(v2): add ImportDocument
feat(v2): add SuggestSmartReplies
parthea added a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot @parthea
fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#464)
f7330f4 
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this issue Oct 21, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#464)
c9342a0 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore(main): release 2.10.1 (#464)
89023ec 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
feat: Add TextDetectionParams.advanced_ocr_options (#464)
dc86d0f 
* feat: Add TextDetectionParams.advanced_ocr_options

Advanced OCR options allow users to customize behavior for a specific OCR engine
version.

PiperOrigin-RevId: 465402148

Source-Link: googleapis/googleapis@ad64930

Source-Link: googleapis/googleapis-gen@5d2c8b2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWQyYzhiMmIxY2IwZDE1YmY3MjQzNTEzYTU1NDNhOWVjM2VjZDc3OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
docs: Add documentation for enums (#464)
020ec09 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#464)
6374729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address third part of 477: Move Dataset.get_entity to Key. dhermes/google-cloud-python
3 participants
@jgeewax @dhermes @yoshi-automation