-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all TODOs from code #146
Comments
Created https://github.com/dhermes/gcloud-python/tree/move-todos-to-issue-tracker to track this. |
This was referenced Sep 22, 2014
Closed
First step b5e8322 |
I think dhermes@f4a9412 doesn't require a follow-up bug. WDYT @silvolu? |
This was referenced Sep 22, 2014
Closed
Closed
parthea
added a commit
that referenced
this issue
Aug 15, 2023
* ci(python): run lint / unit tests / docs as GH actions Source-Link: googleapis/synthtool@57be0cd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6 * add commit to trigger gh action Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this issue
Sep 14, 2023
* docs: Minor formatting PiperOrigin-RevId: 557516220 Source-Link: googleapis/googleapis@ba5bae4 Source-Link: googleapis/googleapis-gen@8207465 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODIwNzQ2NTNmNzdkZDNjMGNlNzlkYjJiY2M1N2EyODg4Y2YwOThmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this issue
Sep 20, 2023
#146) * chore: use gapic-generator-python 0.62.1 * fix: resolve DuplicateCredentialArgs error when using credentials_file committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * lint Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this issue
Sep 20, 2023
parthea
pushed a commit
that referenced
this issue
Sep 20, 2023
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
parthea
added a commit
that referenced
this issue
Sep 22, 2023
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
Source-Link: googleapis/synthtool@c5026b3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:0856ca711da1fd5ec9d6d7da6c50aa0bbf550fb94acb47b55159a640791987bf
parthea
pushed a commit
that referenced
this issue
Sep 22, 2023
PiperOrigin-RevId: 373649163 Source-Link: googleapis/googleapis@7e1b14e Source-Link: googleapis/googleapis-gen@0a3c7d2 fix: add async client to %name_%version/init.py chore: add autogenerated snippets chore: remove auth, policy, and options from the reserved names list feat: support self-signed JWT flow for service accounts chore: enable GAPIC metadata generation chore: sort subpackages in %namespace/%name/init.py
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
Source-Link: googleapis/synthtool@b0eb8a8 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6
parthea
added a commit
that referenced
this issue
Oct 21, 2023
* chore: exclude requirements.txt file from renovate-bot Source-Link: googleapis/synthtool@f58d313 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6 * update constraints files * fix(deps): require protobuf 3.20.2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-kms](https://togithub.com/googleapis/python-kms) | `==2.4.0` -> `==2.4.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-kms/2.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-kms/2.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-kms/2.4.1/compatibility-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-kms/2.4.1/confidence-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-kms</summary> ### [`v2.4.1`](https://togithub.com/googleapis/python-kms/blob/master/CHANGELOG.md#​241-httpswwwgithubcomgoogleapispython-kmscomparev240v241-2021-07-20) [Compare Source](https://togithub.com/googleapis/python-kms/compare/v2.4.0...v2.4.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-kms).
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
PiperOrigin-RevId: 373649163 Source-Link: googleapis/googleapis@7e1b14e Source-Link: googleapis/googleapis-gen@0a3c7d2
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
- [ ] Regenerate this pull request now. chore: fix docstring for first attribute of protos committer: @busunkim96 PiperOrigin-RevId: 401271153 Source-Link: googleapis/googleapis@787f8c9 Source-Link: googleapis/googleapis-gen@81decff Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
The tables client documentation got deleted on accident - this re-adds the `TablesClient` and `GcsClient` under `automl_v1beta1`. Verify locally by running `nox -s docs` and looking at the output in `docs/_build/html`. Fixes b/184554120
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea
pushed a commit
that referenced
this issue
Oct 21, 2023
Source-Link: googleapis/synthtool@facee4c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:9743664022bd63a8084be67f144898314c7ca12f0a03e422ac17c733c129d803 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this issue
Oct 22, 2023
Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea
added a commit
that referenced
this issue
Oct 22, 2023
parthea
pushed a commit
that referenced
this issue
Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this issue
Oct 22, 2023
parthea
added a commit
that referenced
this issue
Oct 22, 2023
parthea
pushed a commit
that referenced
this issue
Oct 22, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [1.5.0](https://www.github.com/googleapis/python-trace/compare/v1.4.0...v1.5.0) (2021-10-14) ### Features * add support for python 3.10 ([#146](https://www.github.com/googleapis/python-trace/issues/146)) ([11d2d9e](https://www.github.com/googleapis/python-trace/commit/11d2d9ec1a615600caca6c3e03a28ceac567452f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A quick check gives:
I will be removing all these from the code and filing a bug for each.
The text was updated successfully, but these errors were encountered: