Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt split repo: _python-gke-hub_ #11039

Closed
vchudnov-g opened this issue Apr 5, 2023 · 1 comment
Closed

Adopt split repo: _python-gke-hub_ #11039

vchudnov-g opened this issue Apr 5, 2023 · 1 comment
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:workaround:protoplus Split repo needs BUILD rule configuration to use proto-plus

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 5, 2023 •
edited
Loading

Migrate the split-repo https://github.com/googleapis/python-gke-hub to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:generated Split repo to be migrated here has generated samples migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:library:gapic_auto Library type of the split repo to be migrated here migration:testing:unit Split repo to be migrated here has unit tests migration:issues:open Split repo to be migrated here has open issues when last checked labels Apr 5, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-gke-hub Adopt split repo: _python-gke-hub_ Apr 6, 2023
@vchudnov-g vchudnov-g added migration:pr:none Split repo to be migrated has no pending PRs migration:workaround:protoplus Split repo needs BUILD rule configuration to use proto-plus labels Apr 6, 2023
@parthea
Copy link
Contributor

parthea commented Apr 17, 2023

Blocked by googleapis/proto-plus-python#348

@parthea parthea added the status: blocked Resolving the issue is dependent on other work. label Apr 17, 2023
@parthea parthea added migration:issues:none Split repo to be migrated here had no open issues when last checked and removed migration:issues:open Split repo to be migrated here has open issues when last checked labels Jul 6, 2023
@parthea parthea added migration:pr:pending Split repo to be migrated has pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs labels Sep 22, 2023
@parthea parthea added migration:pr:none Split repo to be migrated has no pending PRs migration:ready and removed status: blocked Resolving the issue is dependent on other work. migration:pr:pending Split repo to be migrated has pending PRs labels Oct 21, 2023
@parthea parthea mentioned this issue Oct 22, 2023
Merged
parthea added a commit that referenced this issue Oct 30, 2023
@parthea
chore(migration): Migrate code from googleapis/python-gke-hub into pa…
4426ddb 
…ckages/google-cloud-gke-hub (#11897)

See #11039. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@parthea parthea mentioned this issue Oct 31, 2023
Merged
@parthea parthea added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Oct 31, 2023
@parthea parthea closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:workaround:protoplus Split repo needs BUILD rule configuration to use proto-plus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g