Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt split repo: _python-gke-backup_ #11037

Closed
vchudnov-g opened this issue Apr 5, 2023 · 3 comments
Closed

Adopt split repo: _python-gke-backup_ #11037

vchudnov-g opened this issue Apr 5, 2023 · 3 comments
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 5, 2023

Migrate the split-repo https://github.com/googleapis/python-gke-backup to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:generated Split repo to be migrated here has generated samples migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:library:gapic_auto Library type of the split repo to be migrated here migration:testing:unit Split repo to be migrated here has unit tests migration:issues:none Split repo to be migrated here had no open issues when last checked labels Apr 5, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-gke-backup Adopt split repo: _python-gke-backup_ Apr 6, 2023
@vchudnov-g vchudnov-g added the migration:pr:none Split repo to be migrated has no pending PRs label Apr 6, 2023
@parthea parthea added migration:pr:pending Split repo to be migrated has pending PRs migration:pr:none Split repo to be migrated has no pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs migration:pr:pending Split repo to be migrated has pending PRs labels May 31, 2023
@parthea
Copy link
Contributor

parthea commented Jul 7, 2023

Wait for cl/546268592 and googleapis/gapic-generator-python#1687

@parthea
Copy link
Contributor

parthea commented Aug 14, 2023

I checked the workarounds in owlbot.py and none of them are needed. We just need to migrate to the standard owlbot.py

@suztomo suztomo self-assigned this Aug 15, 2023
@suztomo
Copy link
Member

suztomo commented Aug 15, 2023

Memo: Issues and pull requests are zero. README or About hasn't been updated. No Cloud document reference.

~/python-gke-backup $ find samples -type f -name "*.py" ! -path "samples/generated_samples/*" | wc -l
       0

Confirmed that https://github.com/googleapis/google-cloud-python/tree/main/packages does not have gke-backup yet.

Next step: "We just need to migrate to the standard owlbot.py". Current owlbot.py: https://github.com/googleapis/python-gke-backup/blob/main/owlbot.py :

for library in s.get_staging_dirs(default_version):
    if clean_up_generated_samples:
        shutil.rmtree("samples/generated_samples", ignore_errors=True)
        clean_up_generated_samples = False

    # Apply workarounds to fix the generated docstrings.
    # Issue filed upstream in https://github.com/googleapis/gapic-generator-python/issues/1345
    s.replace(
        library / f"google/cloud/gke_backup_{library.name}/**/*.py",
        """must:[\n]*
                 - be between 1 and 63 characters long
                \(inclusive\)  - consist of only
                lower-case ASCII letters, numbers, and
                dashes  - start with a lower-case letter
                 - end with a lower-case letter or
                number""",
        """must:

                 - be between 1 and 63 characters long (inclusive) 
                 - consist of only lower-case ASCII letters, numbers, and dashes
                 - start with a lower-case letter
                 - end with a lower-case letter or number"""
    )
...

@parthea parthea added migration:ready and removed migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds labels Aug 16, 2023
@suztomo suztomo assigned suztomo and unassigned suztomo Aug 16, 2023
@vchudnov-g vchudnov-g added the migration:workaround:none Split repo to be migrated here has no manual workarounds label Aug 19, 2023
parthea added a commit that referenced this issue Sep 14, 2023
… packages/google-cloud-gke-backup (#11645)

See #11037. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@parthea parthea added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Sep 14, 2023
@parthea parthea closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds
Projects
None yet
Development

No branches or pull requests

3 participants