Skip to content

Commit

Permalink
Use FQDN for GCE metadata endpoint. (#7520)
Browse files Browse the repository at this point in the history
Closes #7517.
  • Loading branch information
rsalmond authored and tseaver committed Mar 19, 2019
1 parent 0bcda42 commit a9a3f6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion logging/google/cloud/logging/_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from google.cloud.logging.entries import StructEntry
from google.cloud.logging.entries import TextEntry

METADATA_URL = "http://metadata/computeMetadata/v1/"
METADATA_URL = "http://metadata.google.internal./computeMetadata/v1/"

This comment has been minimized.

Copy link
@kalyanac

kalyanac May 24, 2019

Why the trailing dot?

This comment has been minimized.

Copy link
@tseaver

tseaver May 24, 2019

Contributor

@kalyanac Per this comment, it prevents further DNS resolution.

METADATA_HEADERS = {"Metadata-Flavor": "Google"}


Expand Down

0 comments on commit a9a3f6a

Please sign in to comment.