fix(recommender): deprecate resource name helper methods (via synth) (#…

…9863)
googleapis · Nov 20, 2019 · 6d6ffba · 6d6ffba
1 parent 9a216a5
commit 6d6ffba
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 9 deletions.
diff --git a/packages/google-cloud-recommender/docs/_static/custom.css b/packages/google-cloud-recommender/docs/_static/custom.css
@@ -1,4 +1,4 @@
 div#python2-eol {
 	border-color: red;
 	border-width: medium;
-}
+} 
diff --git a/packages/google-cloud-recommender/docs/_templates/layout.html b/packages/google-cloud-recommender/docs/_templates/layout.html
@@ -1,3 +1,4 @@
+
 {% extends "!layout.html" %}
 {%- block content %}
 {%- if theme_fixed_sidebar|lower == 'true' %}

diff --git a/...ges/google-cloud-recommender/google/cloud/recommender_v1beta1/gapic/recommender_client.py b/...ges/google-cloud-recommender/google/cloud/recommender_v1beta1/gapic/recommender_client.py
@@ -81,7 +81,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def recommendation_path(cls, project, location, recommender, recommendation):
-        """Return a fully-qualified recommendation string."""
+        """DEPRECATED. Return a fully-qualified recommendation string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/recommenders/{recommender}/recommendations/{recommendation}",
             project=project,
@@ -92,7 +97,12 @@ def recommendation_path(cls, project, location, recommender, recommendation):
 
     @classmethod
     def recommender_path(cls, project, location, recommender):
-        """Return a fully-qualified recommender string."""
+        """DEPRECATED. Return a fully-qualified recommender string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/recommenders/{recommender}",
             project=project,

diff --git a/packages/google-cloud-recommender/synth.metadata b/packages/google-cloud-recommender/synth.metadata
@@ -1,26 +1,26 @@
 {
-  "updateTime": "2019-10-05T12:31:38.542410Z",
+  "updateTime": "2019-11-20T13:28:29.755927Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.38.0",
-        "dockerImage": "googleapis/artman@sha256:0d2f8d429110aeb8d82df6550ef4ede59d40df9062d260a1580fce688b0512bf"
+        "version": "0.42.1",
+        "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "ceb8e2fb12f048cc94caae532ef0b4cf026a78f3",
-        "internalRef": "272971705"
+        "sha": "16543773103e2619d2b5f52456264de5bb9be104",
+        "internalRef": "281423227"
       }
     },
     {
       "template": {
         "name": "python_library",
         "origin": "synthtool.gcp",
-        "version": "2019.5.2"
+        "version": "2019.10.17"
       }
     }
   ],