Add iot #937
Merged
Add iot #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbausor
requested review from
chingor13,
dwsupplee,
jdpedrie and
tmatsuo
as code owners
googlebot
added
the
cla: yes
michaelbausor
added
do not merge
|
Updated with partial veneer, PTAL |
dwsupplee
approved these changes
Mar 21, 2018
src/Iot/V1/DeviceManagerClient.php
Outdated
| throw new InvalidArgumentException( | ||
| 'The "grpc" transport is not currently supported, ' . | ||
| 'please use the "rest" transport.'); | ||
| } else { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Updated to new repo structure |
jdpedrie
approved these changes
Mar 26, 2018
jdpedrie
added
the
do not merge
|
looks good again! |
|
Funny travis failure, that repeated when I tried to re-run the build. Have you guys seen that one before? |
|
I've been trying to track down a travis-only segfault in #923 as well. I don't recall seeing a persistent segfault only on PHP 7.0 though. |
|
Same here, that seems new. |
michaelbausor
removed
the
do not merge
Merged
dwsupplee
added a commit
that referenced
this pull request
Apr 2, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge, pending googleapis/gax-php#149 and partial veneer to allow REST only