Debugger: Logpoint name #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tmatsuo
reviewed
Feb 12, 2018
src/Debugger/Agent.php
Outdated
| @@ -47,6 +47,8 @@ class Agent | |||
| use BatchDaemonTrait; | |||
| use SysvTrait; | |||
|
|
|||
| const DEFAULT_LOGPOINT_LOG_NAME = 'appengine.googleapis.com%2Frequest_log'; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
approved these changes
Feb 13, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default log name for logpoints should be
appengine.googleapis.com%2Frequest_log. Note that the/is uri encoded here (@dwsupplee - I'm not sure if the user should be expected to escape the log name).Naming the log name like this allows the Debug UI to show logpoints in a special location on the same page without having to navigate to the Logging UI.
Also prefixes the logpoint message with
LOGPOINT:to match what other languages' agents are doing.