Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: windows path names #890

Merged
merged 4 commits into from
Feb 8, 2018
Merged

Debugger: windows path names #890

merged 4 commits into from
Feb 8, 2018

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Feb 8, 2018

Breakpoint source location paths are usually specified using unix style directory separators (/). On windows, the agent should normalize the path when resolving the location. The original location should not be touched otherwise, the UI may not work.

Also fixes running on windows when a configured include path does not exist.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2018
@chingor13 chingor13 requested a review from tmatsuo as a code owner February 8, 2018 00:50
@chingor13 chingor13 changed the title WIP: Debugger: windows path names Debugger: windows path names Feb 8, 2018
@chingor13 chingor13 merged commit 936f18b into googleapis:master Feb 8, 2018
@chingor13 chingor13 deleted the debugger-windows-paths branch February 8, 2018 23:51
gcf-owl-bot bot added a commit that referenced this pull request Apr 30, 2024
Source-Link: googleapis/googleapis@018c0e3

Source-Link: googleapis/googleapis-gen@dad8476
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZGFkODQ3NmM5NGViMWVjYjJmZDcyZjI5NjgyNWU5NjIxZWE4YjQ1ZCJ9
yash30201 pushed a commit that referenced this pull request Apr 30, 2024
* feat: Update Compute Engine API to revision 20240407 (#890)
Source-Link: googleapis/googleapis@018c0e3
Source-Link: googleapis/googleapis-gen@dad8476
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZGFkODQ3NmM5NGViMWVjYjJmZDcyZjI5NjgyNWU5NjIxZWE4YjQ1ZCJ9

* feat: Update Compute Engine API to revision 20240421 (#899)
Source-Link: googleapis/googleapis@55499b5
Source-Link: googleapis/googleapis-gen@cf5049b
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants