Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on 502 errors #877

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Retry on 502 errors #877

merged 1 commit into from
Jan 31, 2018

Conversation

dwsupplee
Copy link
Contributor

We have received guidance to retry requests on a 502 error code.

@dwsupplee dwsupplee added the api: bigquery Issues related to the BigQuery API. label Jan 31, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2018
@michaelbausor
Copy link
Contributor

LGTM for retrying on 502. Do we retry on anything else at the moment?

@dwsupplee
Copy link
Contributor Author

dwsupplee commented Jan 31, 2018 •
edited
Loading

Yes, on rateLimitExceeded and backendError error messages - 502 is the only code we will now retry on. IIRC we were asked not to retry on any codes previously.

@dwsupplee dwsupplee merged commit f3db719 into googleapis:master Jan 31, 2018
@jdpedrie jdpedrie mentioned this pull request Feb 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @michaelbausor @googlebot