Debugger: e2e test #867
Debugger: e2e test #867
Conversation
googlebot
added
the
cla: yes
tests/system/Debugger/E2ETest.php
Outdated
|
|
||
| public static function createComposerJson() | ||
| { | ||
| $branch = exec('git rev-parse --abbrev-ref HEAD'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| }); | ||
| } | ||
|
|
||
| private function setBreakpoint($file, $line) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * then makes a request to the app that should trigger the breakpoint. We then | ||
| * ensure that the breakpoint has been fulfilled. | ||
| * | ||
| * @group debugger |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tests/system/Debugger/E2ETest.php
Outdated
| $branch = exec('git rev-parse --abbrev-ref HEAD'); | ||
| $origin = exec('git remote get-url origin'); | ||
| $repo = 'GoogleCloudPlatform/google-cloud-php'; | ||
| if (preg_match('/[:\/](.+\/[^\/\.]+)(\.git)?/', $origin, $matches)) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tests/system/Debugger/E2ETest.php
Outdated
| public static function createComposerJson() | ||
| { | ||
| $branch = exec('git rev-parse --abbrev-ref HEAD'); | ||
| $origin = exec('git remote get-url origin'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@chingor13 are there any other steps I should take outside of enabling the debugger API in order for the tests to pass? |
|
It should only require debugger api (and your test service account having access to debugger) and the ability to deploy to app engine. There's an additional |
|
I will play around with |
|
@dwsupplee Ah, the line number is invalid that I was setting the breakpoint on. The number changed after I added the license header. |
…efore running the tests
|
@dwsupplee The test should be fixed now. |
|
The tests are now passing for me as well, thanks. |
google/cloud-toollibraryGOOGLE_VERSION_ID,GOOGLE_PROJECT_ID, andRUN_DEPLOYMENT_TESTS=true. This utilizes https://github.com/GoogleCloudPlatform/php-tools/blob/master/src/TestUtils/AppEngineDeploymentTrait.php