Introduce HTTP 1.1/JSON support for GAPIC clients #857

dwsupplee · 2018-01-20T01:52:00Z

Toolkit PR: googleapis/gapic-generator#1787 (review)
GAX PR: googleapis/gax-php#118

Todos:

Tag GAX and update dependency on dev branch.
Refresh generated protos. - Introduce HTTP 1.1/JSON support for GAPIC clients #857 (comment)

jdpedrie · 2018-01-22T15:35:51Z

this is exciting!!

michaelbausor · 2018-01-22T16:38:00Z

One extra step we need to do before we release: we need to refresh all of the generated protos in proto-client-php. Otherwise, we might have refreshed gapic clients, but old protos. I will go through and do this now.

src/Bigtable/V2/BigtableClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Bigtable/Admin/V2/BigtableInstanceAdminClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Bigtable/Admin/V2/BigtableTableAdminClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Container/V1/ClusterManagerClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Core/GrpcRequestWrapper.php

-        Grpc\STATUS_INTERNAL,
-        Grpc\STATUS_UNAVAILABLE,
-        Grpc\STATUS_DATA_LOSS
+        Code::UNKNOWN,


src/VideoIntelligence/V1beta2/VideoIntelligenceServiceClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Vision/V1/Gapic/ImageAnnotatorGapicClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Vision/V1/ImageAnnotatorClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


src/Bigtable/Admin/V2/BigtableInstanceAdminClient.php

 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0


composer.json

        "guzzlehttp/guzzle": "^5.3|^6.0",
        "guzzlehttp/psr7": "^1.2",
        "monolog/monolog": "~1",
        "psr/http-message": "1.0.*",
        "ramsey/uuid": "~3",
        "google/proto-client": "^0.30.0",
-        "google/gax": "^0.29"
+        "google/gax": "dev-json-transport"


chingor13

On the Debugger side, everything looks good here.

tmatsuo · 2018-01-22T20:08:44Z

Is the system test passing?

dwsupplee · 2018-01-22T20:10:46Z

Running them now, will report back!

michaelbausor · 2018-01-22T20:13:35Z

proto-client-php 0.31.0 has been released with updated protos (touching Bigtable, BigtableAdmin, Monitoring and OsLogin)

dwsupplee · 2018-01-22T20:16:57Z

Fantastic! Thanks Mike.

src/Bigtable/Admin/V2/Gapic/BigtableInstanceAdminGapicClient.php

    private static function getProjectNameTemplate()
    {
-        if (self::$projectNameTemplate == null) {
+        if (null == self::$projectNameTemplate) {


tmatsuo

LGTM

Can you also make sure the system test is passing?

src/Bigtable/Admin/V2/BigtableInstanceAdminClient.php

@@ -1,12 +1,12 @@
 <?php
 /*
- * Copyright 2017, Google LLC All rights reserved.
+ * Copyright 2018 Google LLC


dwsupplee · 2018-01-22T22:35:23Z

@tmatsuo System tests came back good.

dwsupplee · 2018-01-22T22:36:14Z

Thanks for the review all!

dwsupplee and others added 17 commits January 19, 2018 19:30

refresh gapics with json-transport updates

80267c2

cs fix

f183f94

regenerate with fix for server streaming calls

7be22b1

update spanner async delete call

db48f78

gapic refresh

0fad551

refresh gapics

bb14a5f

refresh gapics

8d4623c

refresh gapics

a05ebf5

gapic refresh

31d6760

gapic refresh

19f22b2

removes grpc-extension constants in favor of native ones

fa67681

fixes tests for Grpc connections

cb03b05

gapic refresh

394454e

add trace/oslogin

e74ec30

refresh gapics

d81f925

readd partial veneer

2a1b5c2

gapic refresh

4577098

dwsupplee requested review from chingor13, jdpedrie and tmatsuo as code owners January 20, 2018 01:52

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2018

remove auth dependency, as it is already required by GAX

f5c9bb9

tmatsuo reviewed Jan 22, 2018

View reviewed changes

chingor13 reviewed Jan 22, 2018

View reviewed changes

dwsupplee added 2 commits January 22, 2018 15:23

rely on proto-client-php ^0.31

89158b1

use correct copyright year

2030219

jdpedrie reviewed Jan 22, 2018

View reviewed changes

pin to gax 0.30

d68a439

tmatsuo approved these changes Jan 22, 2018

View reviewed changes

src/Bigtable/Admin/V2/BigtableInstanceAdminClient.php Outdated

@@ -1,12 +1,12 @@

<?php

/*

* Copyright 2017, Google LLC All rights reserved.

* Copyright 2018 Google LLC

This comment was marked as spam.

Sign in to view

dwsupplee merged commit 2f18a3a into master Jan 22, 2018

dwsupplee mentioned this pull request Jan 22, 2018

Prepare v0.52.0 #860

Merged

dwsupplee deleted the transport branch January 23, 2018 20:21

Introduce HTTP 1.1/JSON support for GAPIC clients #857

Introduce HTTP 1.1/JSON support for GAPIC clients #857

Conversation

dwsupplee commented Jan 20, 2018 • edited Loading

jdpedrie commented Jan 22, 2018

michaelbausor commented Jan 22, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

chingor13 left a comment

Choose a reason for hiding this comment

tmatsuo commented Jan 22, 2018

dwsupplee commented Jan 22, 2018

michaelbausor commented Jan 22, 2018

dwsupplee commented Jan 22, 2018

This comment was marked as spam.

This comment was marked as spam.

tmatsuo left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

dwsupplee commented Jan 22, 2018

dwsupplee commented Jan 22, 2018

dwsupplee commented Jan 20, 2018 •

edited

Loading