Debugger: detect default source context #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source-contexts.json is deprecated and should not be used. Currently, gcloud produces both, but will only create the singular form in the future.
googlebot
added
the
cla: yes
tmatsuo
approved these changes
Jan 19, 2018
tests/unit/Debugger/DaemonTest.php
Outdated
| $this->client->debuggee(null, Argument::withEntry('extSourceContexts', [$expectedSourceContext])) | ||
| ->willReturn($this->debuggee->reveal())->shouldBeCalled(); | ||
|
|
||
| $root = implode(DIRECTORY_SEPARATOR, [__DIR__, 'example']); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
approved these changes
Jan 19, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
source-contexts.jsonfile is being deprecated in favor ofsource-context.json. The gcloud sdk will stop generating the plural version at some point in the future.This PR switches the default source context parsing to read from the singular version if the file exists.