Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: resolve source location #844

Merged
merged 15 commits into from
Jan 19, 2018
Merged

Debugger: resolve source location #844

merged 15 commits into from
Jan 19, 2018

Conversation

chingor13
Copy link
Contributor

The requested source location may not exist with the exact path (although for most cases it will be).

Adding a SourceLocationResolver class that searches for the requested source location in the source tree. This resolution hits the file system, but is run from the separate daemon process and should not affect each individual request. When the daemon fetches the list of breakpoints, it validates them (including resolving the location) before saving them to the breakpoint storage. The agent that reads from the breakpoint storage can trust that the source location has been normalized (found).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
@chingor13 chingor13 changed the title WIP: Debugger resolve source location WIP: Debugger: resolve source location Jan 11, 2018
@dwsupplee dwsupplee added the api: clouddebugger Issues related to the Cloud Debugger API. label Jan 17, 2018
@chingor13 chingor13 requested a review from tmatsuo as a code owner January 17, 2018 20:34
@chingor13 chingor13 changed the title WIP: Debugger: resolve source location Debugger: resolve source location Jan 18, 2018
@chingor13 chingor13 requested review from tmatsuo, jdpedrie and dwsupplee and removed request for tmatsuo January 18, 2018 19:21
public function __construct($searchPath, $file)
{
parent::__construct(
new \RecursiveIteratorIterator(

This comment was marked as spam.

This comment was marked as spam.

public function accept()
{
$candidate = $this->getInnerIterator()->current();
return strrpos($candidate, $this->file) === strlen($candidate) - strlen($this->file);

This comment was marked as spam.

{
public function testFindsMany()
{
// There are many files that end in Connection/RestTest.php in the test/unit folder

This comment was marked as spam.

This comment was marked as spam.

@chingor13 chingor13 merged commit 5515847 into googleapis:master Jan 19, 2018
@chingor13 chingor13 deleted the debugger-resolve-location branch January 19, 2018 19:04
@dwsupplee dwsupplee mentioned this pull request Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouddebugger Issues related to the Cloud Debugger API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants