Debugger: Default source context and default uniquifier #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extSourceContext field should be empty when there is no source_contexts.json file available. The default uniquifier should be based off a SHA1 of available files to debug (.php files). We add the file size as a proxy for detecting changes.
googlebot
added
the
cla: yes
The paths generated are different on windows so we should not check for the exact value of the generated uniquifier.
tmatsuo
reviewed
Jan 17, 2018
| \RecursiveRegexIterator::GET_MATCH | ||
| ); | ||
|
|
||
| $files = array_keys(iterator_to_array($regex)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
approved these changes
Jan 17, 2018
dwsupplee
approved these changes
Jan 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extSourceContext field should be empty when there is no
source-contexts.jsonfile available.The default uniquifier should be based off a SHA1 of available files to
debug (.php files). We add the file size as a proxy for detecting
changes.