Debugger: Validate breakpoint file and line #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tmatsuo
reviewed
Jan 17, 2018
src/Debugger/Breakpoint.php
Outdated
| } | ||
| } catch (\ParseError $e) { | ||
| // Ensure the file is a php file | ||
| if ($info->getExtension() !== "php") { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Debugger/Breakpoint.php
Outdated
|
|
||
| // Ensure the line exists and is not a comment in the file | ||
| if ($line === false || | ||
| preg_match('/^\s*[\/\*]+/', $line) || |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Jan 17, 2018
| @@ -0,0 +1,156 @@ | |||
| <?php | |||
| /** | |||
| * Copyright 2017 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This won't catch comments that are multiline that don't begin with *.
tmatsuo
reviewed
Jan 17, 2018
src/Debugger/Breakpoint.php
Outdated
| return true; | ||
| } | ||
|
|
||
| private function validateSourceLocation() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
approved these changes
Jan 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional validation to a breakpoint by validating the source location.
The
Daemondoes the validation and immediately reports validation errors back to the stackdriver server.