Pass ServiceBuilder construct config into children #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've been investigating the report in #766, and found that the constructor
$config
is passed to services ONLY when no child$config
is set.For instance:
This strikes me as incorrect, as it prevents e.g. SpeechClient from setting a languageCode and using ServiceBuilder-level credentials. My proposed solution simply merges ServiceBuilder and factory method configuration, preferring keys given later.
If accepted, this PR closes #766.
edit: for a demonstration, pull the PR and run
vendor/bin/phpunit --group=servicebuilder
. Then reset the changes tosrc/Core/ServiceBuilder.php
to the current master branch. Undoing changes to ServiceBuilder will expose errors on SpeechClient.