When executing runQuery wait until complete before returning QueryResults #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jdpedrie
approved these changes
Dec 20, 2017
Merged
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 2, 2023
Source-Link: googleapis/googleapis@3427705 Source-Link: googleapis/googleapis-gen@7a98938 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiN2E5ODkzODA3M2FjMTAyMTY0NDNlYmU2MjRhZTYyNGM4NmNkNmFkYiJ9
bshaffer
pushed a commit
that referenced
this pull request
Jun 2, 2023
Source-Link: googleapis/googleapis@3427705 Source-Link: googleapis/googleapis-gen@7a98938 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiN2E5ODkzODA3M2FjMTAyMTY0NDNlYmU2MjRhZTYyNGM4NmNkNmFkYiJ9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change
BigQueryClient::runQuerywill wait for the job to complete before returningQueryResults, whereas currentlyQueryResultscould be returned prior to job completion and the waiting would occur when a user goes to iterate the results.