Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger notice if keyfile is missing a project ID #803

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Trigger notice if keyfile is missing a project ID #803

merged 2 commits into from
Aug 14, 2018

Conversation

jdpedrie
Copy link
Contributor

Closes #171.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2017
@jdpedrie
Copy link
Contributor Author

cc @tmatsuo

@dwsupplee
Copy link
Contributor

I think this fell off the map because CI wasn't passing. Is it something we can get patched up and rebased with the new repo structure?

@jdpedrie
Copy link
Contributor Author

jdpedrie commented Apr 26, 2018 •
edited
Loading

There were some issues with getting the tests passing; it was a bit more involved than simply updating a unit test. I'll need to circle back and reacquaint myself with it again, then I can give a firmer answer.

@dwsupplee
Copy link
Contributor

@jdpedrie do you think you'll have a chance to look at this again this week?

@jdpedrie
Copy link
Contributor Author

I'll reacquaint myself with it!

@jdpedrie
Copy link
Contributor Author

jdpedrie commented Jul 30, 2018 •
edited
Loading

@dwsupplee this is ready for review.

@tmatsuo @bshaffer I'd appreciate input on potential edge cases with various types of key files where this change might pose an issue. Should I add a toggle to silence the message?

dwsupplee
dwsupplee suggested changes Jul 30, 2018
View reviewed changes
Core/src/ClientTrait.php Outdated

trigger_error(
'A keyfile was given, but it does not contain a project ID. ' .
'This can indicate an old and obsolete keyfile, in which case you should create a new one.',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee
dwsupplee approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's wait for a sound off from Takashi or Brent before merging.

@jdpedrie jdpedrie merged commit e57419c into googleapis:master Aug 14, 2018
@jdpedrie jdpedrie deleted the keyfile-notice branch August 14, 2018 14:28
@jdpedrie jdpedrie mentioned this pull request Aug 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdpedrie @dwsupplee @tmatsuo @googlebot