Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for results indefinitely #798

Merged
merged 3 commits into from
Dec 19, 2017
Merged

Wait for results indefinitely #798

merged 3 commits into from
Dec 19, 2017

Conversation

jdpedrie
Copy link
Contributor

No description provided.

@jdpedrie jdpedrie added the api: bigquery Issues related to the BigQuery API. label Dec 15, 2017
@jdpedrie jdpedrie requested a review from dwsupplee as a code owner December 15, 2017 19:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2017
@michaelbausor
Copy link
Contributor

I think we also want to update docs in places like here: https://github.com/GoogleCloudPlatform/google-cloud-php/blob/master/src/BigQuery/QueryResults.php#L129

dwsupplee
dwsupplee suggested changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs on QueryResults for maxRetries need to be updated, otherwise LGTM! :)

@jdpedrie
Copy link
Contributor Author

@dwsupplee all set

@dwsupplee dwsupplee merged commit dc32fe1 into googleapis:master Dec 19, 2017
@jdpedrie jdpedrie deleted the bigquery-review-fixes branch December 19, 2017 16:39
@jdpedrie jdpedrie mentioned this pull request Dec 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdpedrie @michaelbausor @dwsupplee @googlebot