Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Compute): update samples to use new surface #7907

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Dec 10, 2024

Use new surface clients for compute samples and link to them in the documentation

@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Dec 10, 2024
@bshaffer bshaffer changed the title feat(Compute): update migration mode to MIGRATING chore(Compute): update samples to use new surface Dec 10, 2024
@bshaffer bshaffer changed the title chore(Compute): update samples to use new surface docs(Compute): update samples to use new surface Dec 10, 2024
@bshaffer bshaffer added the next release PRs to be included in the next release label Dec 10, 2024
@bshaffer bshaffer marked this pull request as ready for review December 10, 2024 19:34
@bshaffer bshaffer requested review from a team as code owners December 10, 2024 19:34
Copy link

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

Separate from this, I think the CODEOWNERS is incorrect as CICD probably shouldn't get tagged for all the things :) but feels like that's a bigger lift figuring out the right teams as I'm guessing from a samples perspective there isn't the equivalent setup right now in googleapis as GoogleCloudPlatform.

@bshaffer bshaffer merged commit e6f8670 into main Dec 11, 2024
33 checks passed
@bshaffer bshaffer deleted the compute-migrating branch December 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants