Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for read-only transactions and transaction options #773

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Add support for read-only transactions and transaction options #773

merged 1 commit into from
Jan 31, 2018

Conversation

jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Dec 4, 2017 •
edited
Loading

This change adds support for Datastore Transaction Options and Read-Only Transactions.

@jdpedrie jdpedrie added api: datastore Issues related to the Datastore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 4, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2017
@jdpedrie jdpedrie removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 4, 2017
dwsupplee
dwsupplee suggested changes Dec 11, 2017
View reviewed changes
src/Datastore/Connection/ConnectionInterface.php Outdated
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2016 Google Inc. All Rights Reserved.
* Copyright 2017 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

src/Datastore/DatastoreClient.php Outdated
*
* @type string $previous If the transaction is being restarted,
* the previous transaction ID.
* @type array $transactionOptions Any other transaction configuration,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/Datastore/DatastoreClient.php Outdated
// if empty, force request to encode as {} rather than [].
'readWrite' => $transactionOptions ?: (object) []
]
] + $options);

This comment was marked as spam.

Sign in to view

dwsupplee
dwsupplee reviewed Dec 11, 2017
View reviewed changes
src/Datastore/DatastoreClient.php Outdated
* @param array $options {
* Configuration options.
*
* @type string $previous If the transaction is being restarted,

This comment was marked as spam.

Sign in to view

@jdpedrie jdpedrie added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 11, 2017
@jdpedrie
Copy link
Contributor Author

@danoscarmike is this feature released in the API yet? Last I heard we were waiting for it to be released in Datastore before adding it to the client library.

dwsupplee
dwsupplee suggested changes Jan 31, 2018
View reviewed changes
src/Datastore/Blob.php Outdated
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2016 Google Inc.
* Copyright 2017 Google Inc.

This comment was marked as spam.

Sign in to view

@jdpedrie jdpedrie removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 31, 2018
@dwsupplee dwsupplee merged commit ef18870 into googleapis:master Jan 31, 2018
@jdpedrie jdpedrie deleted the datastore-transactions branch January 31, 2018 22:59
@jdpedrie jdpedrie mentioned this pull request Feb 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpedrie @dwsupplee @googlebot