Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: promote BeyondCorp APIs to v1 #7436

Merged
merged 2 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .repo-metadata-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
"BeyondCorpAppConnections": {
"language": "php",
"distribution_name": "google/cloud-beyondcorp-appconnections",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-beyondcorp-appconnections/latest",
"library_type": "GAPIC_AUTO",
"product_documentation": "https://cloud.google.com/beyondcorp-enterprise/docs",
Expand All @@ -200,31 +200,31 @@
"BeyondCorpAppConnectors": {
"language": "php",
"distribution_name": "google/cloud-beyondcorp-appconnectors",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-beyondcorp-appconnectors/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "beyondcorp"
},
"BeyondCorpAppGateways": {
"language": "php",
"distribution_name": "google/cloud-beyondcorp-appgateways",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-beyondcorp-appgateways/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "beyondcorp"
},
"BeyondCorpClientConnectorServices": {
"language": "php",
"distribution_name": "google/cloud-beyondcorp-clientconnectorservices",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-beyondcorp-clientconnectorservices/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "beyondcorp"
},
"BeyondCorpClientGateways": {
"language": "php",
"distribution_name": "google/cloud-beyondcorp-clientgateways",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-beyondcorp-clientgateways/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "beyondcorp"
Expand Down
4 changes: 2 additions & 2 deletions BeyondCorpAppConnections/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
deep-copy-regex:
- source: /google/cloud/beyondcorp/appconnections/v1/.*-php/(.*)
dest: /owl-bot-staging/BeyondCorpAppConnections/v1/$1
- source: /google/cloud/beyondcorp/appconnections/(v1)/.*-php/(.*)
dest: /owl-bot-staging/BeyondCorpAppConnections/$1/$2
api-name: BeyondCorpAppConnections
40 changes: 4 additions & 36 deletions BeyondCorpAppConnections/owlbot.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2022 Google LLC
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -30,13 +30,7 @@
# Added so that we can pass copy_excludes in the owlbot_main() call
_tracked_paths.add(src)

php.owlbot_main(
src=src,
dest=dest,
copy_excludes=[
src / "**/[A-Z]*_*.php"
]
)
php.owlbot_main(src=src, dest=dest)

# remove class_alias code
s.replace(
Expand All @@ -47,32 +41,6 @@
+ "\n",
'')

### [START] protoc backwards compatibility fixes

# roll back to private properties.
s.replace(
"src/**/V*/**/*.php",
r"Generated from protobuf field ([^\n]{0,})\n\s{5}\*/\n\s{4}protected \$",
r"""Generated from protobuf field \1
*/
private $""")

# Replace "Unwrapped" with "Value" for method names.
s.replace(
"src/**/V*/**/*.php",
r"public function ([s|g]\w{3,})Unwrapped",
r"public function \1Value"
)

### [END] protoc backwards compatibility fixes

# fix relative cloud.google.com links
s.replace(
"src/**/V*/**/*.php",
r"(.{0,})\]\((/.{0,})\)",
r"\1](https://cloud.google.com\2)"
)

# format generated clients
subprocess.run([
'npm',
Expand All @@ -81,8 +49,8 @@
'--package=@prettier/plugin-php@^0.16',
'--',
'prettier',
'**/Gapic/*',
'**/Client/*',
'--write',
'--parser=php',
'--single-quote',
'--print-width=80'])
'--print-width=120'])
18 changes: 9 additions & 9 deletions BeyondCorpAppConnections/src/V1/AppConnection.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions BeyondCorpAppConnections/src/V1/AppConnection/Gateway.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 0 additions & 34 deletions BeyondCorpAppConnections/src/V1/AppConnectionsServiceClient.php

This file was deleted.

Loading
Loading