Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spanner): Batch Write Feature #7420

Merged
merged 19 commits into from
Jun 25, 2024
Merged

feat(Spanner): Batch Write Feature #7420

merged 19 commits into from
Jun 25, 2024

Conversation

yash30201
Copy link
Contributor

Implement the BatchWrite feature as per the design doc go/php-spanner-batch-write.

See parent bug: b/336433631

@yash30201 yash30201 requested review from a team as code owners June 14, 2024 19:57
@yash30201 yash30201 added api: spanner Issues related to the Spanner API. next release PRs to be included in the next release labels Jun 14, 2024
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an initial review because I am blocked until I can find how to test the Grpc::batchWrite function.

Spanner/src/Connection/Grpc.php Outdated Show resolved Hide resolved
Spanner/src/Connection/Grpc.php Show resolved Hide resolved
Spanner/src/Connection/Grpc.php Show resolved Hide resolved
@bshaffer bshaffer enabled auto-merge (squash) June 25, 2024 16:28
@bshaffer bshaffer merged commit 5f18eb2 into main Jun 25, 2024
25 checks passed
@bshaffer bshaffer deleted the spanner-batch-write branch June 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants