Allow unauthenticated requests and do not always require project ID #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
LGTM. I looked for a test that did an unauthenticated download of a storage object, but didn't see one - did I miss it? |
|
Working on adding one now, as well as fixing the test failure on travis (passed for me locally, so trying to figure out what went wrong). |
|
Looks like some environment variables on travis' end were the cause of the failure, PTAL - should be all set. |
|
Tricky! LGTM |
Merged
tmatsuo
reviewed
Nov 15, 2017
| $this->projectId = $this->detectProjectId($config); | ||
|
|
||
| if (!$config['keyFile'] && !isset($config['credentialsFetcher'])) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we longer always require a projectId/credentials. The driving factor behind this change is to allow for unauthenticated downloads of objects from cloud storage, but it may end up being useful for other APIs down the line as well.