feat: [Dataplex] updated client libraries for Dataplex Catalog: removed deprecated fields, updated comments #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
…ed fields, updated comments fix!: An existing field `entry` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` fix!: An existing field `display_name` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` fix!: An existing field `entry_type` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` fix!: An existing field `modify_time` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` fix!: An existing field `fully_qualified_name` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` fix!: An existing field `description` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` fix!: An existing field `relative_resource` is removed from message `.google.cloud.dataplex.v1.SearchEntriesResult` docs: A comment for field `aspects` in message `.google.cloud.dataplex.v1.Entry` is changed docs: A comment for field `filter` in message `.google.cloud.dataplex.v1.ListEntriesRequest` is changed PiperOrigin-RevId: 630090353 Source-Link: googleapis/googleapis@7ea9f2c Source-Link: googleapis/googleapis-gen@7a1cca7 Copy-Tag: eyJwIjoiRGF0YXBsZXgvLk93bEJvdC55YW1sIiwiaCI6IjdhMWNjYTc5ODJlNWFjZTI5NWFhYWQxOTQyNjdjYzVkMDVjMTFkNTgifQ==
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
bshaffer
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix!: An existing field
entryis removed from message.google.cloud.dataplex.v1.SearchEntriesResultfix!: An existing field
display_nameis removed from message.google.cloud.dataplex.v1.SearchEntriesResultfix!: An existing field
entry_typeis removed from message.google.cloud.dataplex.v1.SearchEntriesResultfix!: An existing field
modify_timeis removed from message.google.cloud.dataplex.v1.SearchEntriesResultfix!: An existing field
fully_qualified_nameis removed from message.google.cloud.dataplex.v1.SearchEntriesResultfix!: An existing field
descriptionis removed from message.google.cloud.dataplex.v1.SearchEntriesResultfix!: An existing field
relative_resourceis removed from message.google.cloud.dataplex.v1.SearchEntriesResultdocs: A comment for field
aspectsin message.google.cloud.dataplex.v1.Entryis changeddocs: A comment for field
filterin message.google.cloud.dataplex.v1.ListEntriesRequestis changedPiperOrigin-RevId: 630090353
Source-Link: googleapis/googleapis@7ea9f2c
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7a1cca7982e5ace295aaad194267cc5d05c11d58
Copy-Tag: eyJwIjoiRGF0YXBsZXgvLk93bEJvdC55YW1sIiwiaCI6IjdhMWNjYTc5ODJlNWFjZTI5NWFhYWQxOTQyNjdjYzVkMDVjMTFkNTgifQ==
BREAKING_CHANGE_REASON=These fields are in protobuf, so there's nothing we can do other than take the breaking change (or bump a major version). As this API is still pre-1.0, we should just take the breaking change. Additionally, the API team has conveyed these fields were part of a service in private preview, so this should not impact many customers.