feat: [SecretManager] Add Secret Version Delayed Destroy changes for client libraries #7250
Conversation
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
docs: Users can now enable secret version delayed destruction PiperOrigin-RevId: 626820938 Source-Link: googleapis/googleapis@0345704 Source-Link: googleapis/googleapis-gen@2532a56 Copy-Tag: eyJwIjoiU2VjcmV0TWFuYWdlci8uT3dsQm90LnlhbWwiLCJoIjoiMjUzMmE1NjdlYTQ3NDljNWY1ZTFjMGJiN2EzZjcxMGIwNjI3OTM5MCJ9
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| * | ||
| * @return string The formatted project_location_secret_secret_version resource. | ||
| */ | ||
| public static function projectLocationSecretSecretVersionName(string $project, string $location, string $secret, string $secretVersion): string |
There was a problem hiding this comment.
I think it would be better to name it as projectLocationSecretVersionName instead of projectLocationSecretSecretVersionName!
There was a problem hiding this comment.
This is auto-generated, and it is created from the URL template by concatenating all the variable names in the URL. In this case, the URL template is:
- projectLocationSecretSecretVersion: projects/{project}/locations/{location}/secrets/{secret}/versions/{secret_version}
As you can see, because the last variable is called secret_version, and the one before it is called secret, the method name ends up having SecretSecret. This is not ideal, but the fix for this would require changing the variable name in the API (it's too late for this), or writing a custom fix in the generator (this is hacky and error prone).
There was a problem hiding this comment.
Hmm.. Will merge this for now then, thank you Brent for the confirmation.
docs: Users can now enable secret version delayed destruction
PiperOrigin-RevId: 626820938
Source-Link: googleapis/googleapis@0345704
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2532a567ea4749c5f5e1c0bb7a3f710b06279390
Copy-Tag: eyJwIjoiU2VjcmV0TWFuYWdlci8uT3dsQm90LnlhbWwiLCJoIjoiMjUzMmE1NjdlYTQ3NDljNWY1ZTFjMGJiN2EzZjcxMGIwNjI3OTM5MCJ9