-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce AppsChat #7215
feat: introduce AppsChat #7215
Conversation
Here is the summary of changes. You are about to add 22 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock. It seems logical to have both Google\Apps\Chat\*
and Google\Apps\Card\*
for now under AppsChat/src
folder.
I checked the namespaces they seem correctly defined in composer.json
files.
b/326631249
Note: The
AppsChat
package also contains the protos fromgoogle/apps/card
. This is because:google/apps/card
.google/apps/card
, we can create a new package (google/apps-shared-protos
) to contain the protos ingoogle/apps/card
, and any others which exist at the time.IF there are other use cases which I am not aware of, where a customer would want to use the protos in
google/apps/card
without using theAppsChat
package, that would be another good reason to split them out now. I'm happy to do so if that's the case, but I wanted to keep this simple for now if we don't have a use-case for doing so.