Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Storage): fix IAM system tests #7206

Merged
merged 1 commit into from
Apr 5, 2024
Merged

chore(Storage): fix IAM system tests #7206

merged 1 commit into from
Apr 5, 2024

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Apr 5, 2024

$policy['bindings'] can have shuffled keys in each element.

The assertContains method in PHPUnit uses a loose comparison (==) to check if an array contains provided value but the order of keys in the arrays matters.

in_array also uses a loose comparison (==), but it doesn't care about the order of keys in arrays.

b/333035372

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 5, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review April 5, 2024 11:07
@vishwarajanand vishwarajanand requested review from a team as code owners April 5, 2024 11:07
@vishwarajanand vishwarajanand changed the title chore(Storage): fix system tests chore(Storage): fix IAM system tests Apr 5, 2024
@yash30201 yash30201 merged commit e22a5b4 into main Apr 5, 2024
30 checks passed
@yash30201 yash30201 deleted the issue-b/333035372 branch April 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants