feat(longrunning): [LongRunning] enable PHP GAPIC v2 surface generation #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
3 tasks
noahdietz
reviewed
Apr 3, 2024
| return $this->getMockBuilder(CredentialsWrapper::class)->disableOriginalConstructor()->getMock(); | ||
| } | ||
|
|
||
| /** @return \Google\LongRunning\Client\OperationsClient */ |
There was a problem hiding this comment.
These need to be \Google\ApiCore\LongRunning\Client\OperationsClient I believe...
noahdietz
reviewed
Apr 3, 2024
| $options += [ | ||
| 'credentials' => $this->createCredentials(), | ||
| ]; | ||
| return new \Google\LongRunning\Client\OperationsClient($options); |
There was a problem hiding this comment.
Ah this too, this needs to be \Google\ApiCore\LongRunning\Client\OperationsClient too
There was a problem hiding this comment.
This is the source of the build failures
|
Owl bot is regenerating pull request 7196... |
PiperOrigin-RevId: 621298668 Source-Link: googleapis/googleapis@1406704 Source-Link: googleapis/googleapis-gen@faf9f39 Copy-Tag: eyJwIjoiTG9uZ1J1bm5pbmcvLk93bEJvdC55YW1sIiwiaCI6ImZhZjlmMzk2MDkyYzkwMmE5Yzg5OGM4Y2UyZWYzNTY1MjI4NTJiYzUifQ==
gcf-owl-bot
bot
force-pushed
the
owl-bot-copy-LongRunning
branch
from
c05600e to
6baf62d
Compare
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Changes generated as part of #6675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 621298668
Source-Link: googleapis/googleapis@1406704
Source-Link: https://github.com/googleapis/googleapis-gen/commit/faf9f396092c902a9c898c8ce2ef356522852bc5
Copy-Tag: eyJwIjoiTG9uZ1J1bm5pbmcvLk93bEJvdC55YW1sIiwiaCI6ImZhZjlmMzk2MDkyYzkwMmE5Yzg5OGM4Y2UyZWYzNTY1MjI4NTJiYzUifQ==