Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SecurityCenter): Add new V2 client surface #7142

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat(SecurityCenter): Add new V2 client surface #7142

merged 1 commit into from
Mar 21, 2024

Conversation

ajupazhamayil
Copy link
Contributor

@ajupazhamayil ajupazhamayil commented Mar 13, 2024 •
edited
Loading

PiperOrigin-RevId: 613632579
b/328626713

@ajupazhamayil ajupazhamayil requested review from a team as code owners March 13, 2024 05:42
@product-auto-label product-auto-label bot added the api: securitycenter Issues related to the Security Command Center API. label Mar 13, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 13, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 40 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ajupazhamayil
Copy link
Contributor Author

The Owlbot automation not working even after adding v2 to the .Owlbot.yaml file of SecurityCenter, hence creating a manual PR.

@ajupazhamayil ajupazhamayil self-assigned this Mar 13, 2024
@ajupazhamayil ajupazhamayil added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 13, 2024
@ajupazhamayil ajupazhamayil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 20, 2024
@ajupazhamayil ajupazhamayil requested a review from yash30201 March 20, 2024 15:42
yash30201
yash30201 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that now we just have V2 client changes.

LGTM!

SecurityCenter/.repo-metadata.json Outdated Show resolved Hide resolved
SecurityCenter/README.md Outdated Show resolved Hide resolved
@ajupazhamayil ajupazhamayil merged commit a6c4add into main Mar 21, 2024
25 checks passed
@ajupazhamayil ajupazhamayil deleted the securitycenter-v2 branch March 21, 2024 06:43
@release-please release-please bot mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash30201 yash30201 yash30201 approved these changes

Assignees

@ajupazhamayil ajupazhamayil

Labels
api: securitycenter Issues related to the Security Command Center API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajupazhamayil @yash30201