Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DialogflowCx] add new client library surface for Dialogflow CX PHP #6906

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 21, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 592861461

Source-Link: googleapis/googleapis@1c2be6e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/81d312381fda2fc18f18b71f46051b36cf5e71cf
Copy-Tag: eyJwIjoiRGlhbG9nZmxvd0N4Ly5Pd2xCb3QueWFtbCIsImgiOiI4MWQzMTIzODFmZGEyZmMxOGYxOGI3MWY0NjA1MWIzNmNmNWU3MWNmIn0=

BREAKING_CHANGE_REASON=removing previous client surface in favor of new ones (new clients should get the new surface only)

PiperOrigin-RevId: 592861461

Source-Link: googleapis/googleapis@1c2be6e

Source-Link: googleapis/googleapis-gen@81d3123
Copy-Tag: eyJwIjoiRGlhbG9nZmxvd0N4Ly5Pd2xCb3QueWFtbCIsImgiOiI4MWQzMTIzODFmZGEyZmMxOGYxOGI3MWY0NjA1MWIzNmNmNWU3MWNmIn0=
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 21, 2023 17:57
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners December 21, 2023 17:57
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2023
@bshaffer
Copy link
Contributor

This addresses #6835 but we also should remove the old clients

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2023
@bshaffer bshaffer enabled auto-merge (squash) December 22, 2023 15:24
@bshaffer
Copy link
Contributor

bshaffer commented Dec 22, 2023

I've also removed the previous client (packagist only has 14 installs, so this should be safe)

@bshaffer bshaffer merged commit 4042b12 into main Dec 22, 2023
27 of 28 checks passed
@bshaffer bshaffer deleted the owl-bot-copy-DialogflowCx branch December 22, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant