Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Bigtable] Modify ModifyColumnFamiliesRequest proto to expose ignore_warnings field #6877

Merged
merged 2 commits into from
Dec 15, 2023
Merged

feat: [Bigtable] Modify ModifyColumnFamiliesRequest proto to expose ignore_warnings field #6877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fd3363
feat: Modify ModifyColumnFamiliesRequest proto to expose ignore_warni…
gcf-owl-bot[bot] Dec 14, 2023
393cda8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Bigtable/metadata/Admin/V2/BigtableTableAdmin.php
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions Bigtable/src/Admin/V2/Gapic/BigtableTableAdminGapicClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,6 +1600,8 @@ public function listTables($parent, array $optionalArgs = [])
* @param array $optionalArgs {
* Optional.
*
* @type bool $ignoreWarnings
* Optional. If true, ignore safety checks when modifying the column families.
* @type RetrySettings|array $retrySettings
* Retry settings to use for this call. Can be a {@see RetrySettings} object, or an
* associative array of retry settings parameters. See the documentation on
Expand All @@ -1617,6 +1619,10 @@ public function modifyColumnFamilies($name, $modifications, array $optionalArgs
$request->setName($name);
$request->setModifications($modifications);
$requestParamHeaders['name'] = $name;
if (isset($optionalArgs['ignoreWarnings'])) {
$request->setIgnoreWarnings($optionalArgs['ignoreWarnings']);
}

$requestParams = new RequestParamsHeaderDescriptor($requestParamHeaders);
$optionalArgs['headers'] = isset($optionalArgs['headers']) ? array_merge($requestParams->getHeader(), $optionalArgs['headers']) : $requestParams->getHeader();
return $this->startCall('ModifyColumnFamilies', Table::class, $optionalArgs, $request)->wait();
Expand Down
34 changes: 34 additions & 0 deletions Bigtable/src/Admin/V2/ModifyColumnFamiliesRequest.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.