-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add universe domain support to core, bigquery, storage, and pubsub #6850
Conversation
Co-authored-by: Vishwaraj Anand <[email protected]>
I observed that Upon discussion with @bshaffer, it seems that TPC uses jwt, so if I call We can change it to something like: return [
'access_token' => $access_token,
'expires_in' => $this->auth->getExpiry(),
'token_type' => 'Bearer',
]; |
To be fair, this is a behavioral difference between SSJs and the oauth token endpoint, and is not related to the Universe Domain support (although it did help us uncover the discrepancy) |
Is my environment broken or is this an actual issue with the token? |
You are using the GDU endpoint (bigquery.googleapis.com) instead of the URL for the Universe Domain you've provided ( |
Co-authored-by: Vishwaraj Anand <[email protected]>
4de3589
to
339e761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some merge conflicts, otherwise LGTM
Add support for Universe Domain to
BigQuery
andStorage
via modifications toRequestWrapper
,RequestWrapperTrait
, andRestTrait
. Add support inPubSub
viaGrpcTrait
.Still needs:
Translate
is the only Client that accepts a "key" argument for API Keys, butshouldSignRequest
can bypass credential checkshouldSignRequest
bypasses the check (and the sending of credentials)