Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Deploy] Add custom target type support #6841

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat: [Deploy] Add custom target type support #6841

merged 2 commits into from
Dec 7, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 4, 2023

  • Regenerate this pull request now.

feat: Add revision tagging for one of the Cloud Run deployment strategies
docs: Fixed a number of comments.

PiperOrigin-RevId: 587671915

Source-Link: googleapis/googleapis@1523043

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d0ab47de58741dba7a2a4300f10bd2b853f0a6cf
Copy-Tag: eyJwIjoiRGVwbG95Ly5Pd2xCb3QueWFtbCIsImgiOiJkMGFiNDdkZTU4NzQxZGJhN2EyYTQzMDBmMTBiZDJiODUzZjBhNmNmIn0=

@gcf-owl-bot
feat: Add custom target type support
a5fcce1 
feat: Add revision tagging for one of the Cloud Run deployment strategies
docs: Fixed a number of comments.

PiperOrigin-RevId: 587671915

Source-Link: googleapis/googleapis@1523043

Source-Link: googleapis/googleapis-gen@d0ab47d
Copy-Tag: eyJwIjoiRGVwbG95Ly5Pd2xCb3QueWFtbCIsImgiOiJkMGFiNDdkZTU4NzQxZGJhN2EyYTQzMDBmMTBiZDJiODUzZjBhNmNmIn0=
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 4, 2023 15:02
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners December 4, 2023 15:02
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 4, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
@ajupazhamayil
Copy link
Contributor

Normally samples will have a helper method to call them like this: https://github.com/googleapis/google-cloud-php/pull/6841/files#diff-2ceaaf92b175172dc2ba18e20d1587dd35c5c3e99f61f2d4e94db5f18370edbdR71

But this particular sample clouddeploy_v1_generated_CloudDeploy_UpdateCustomTargetType_sync does not have a helper method, see here: https://github.com/googleapis/google-cloud-php/pull/6841/files#diff-c7dd28f7caab5c35694c3dbc2b3bb32c40a7bfcf6d63144f85f508d9332ea78fR43

Not sure why!

@ajupazhamayil ajupazhamayil added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 5, 2023
@ajupazhamayil ajupazhamayil merged commit c053e8e into main Dec 7, 2023
24 checks passed
@ajupazhamayil ajupazhamayil deleted the owl-bot-copy-Deploy branch December 7, 2023 09:02
@release-please release-please bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajupazhamayil ajupazhamayil ajupazhamayil approved these changes

Assignees
No one assigned
Labels
owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajupazhamayil