ensures PSR log level can be int or string

[bshaffer]

casts $level to an integer to ensure it can be handled by gRPC in PsrLogger. Otherwise, passing in a string (such as "emergency") raises the following error:

PHP Notice:  Undefined index: warning in vendor/google/cloud-logging/Connection/Grpc.php on line 315

Notice: Undefined index: warning in vendor/google/cloud-logging/Connection/Grpc.php on line 315

                   
  [Exception]      
  Expect integer.  
                   

[jdpedrie]

Hey @bshaffer, looks like this change will require system test updates as well:

➜ vendor/bin/phpunit -c phpunit-system.xml.dist --group=logging
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

.............................E.E.E.E.E.E.E.E

Time: 1.26 minutes, Memory: 18.00MB

There were 8 errors:

1) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesEmergencyLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 800

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:153
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:165

2) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesAlertLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 700

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:170
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:173

3) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesCriticalLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 600

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:187
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:181

4) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesErrorLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 500

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:204
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:189

5) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesWarningLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 400

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:221
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:197

6) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesNoticeLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 300

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:238
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:205

7) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesInfoLogWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 200

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:255
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:213

8) Google\Cloud\Tests\System\Logging\WriteAndListEntryTest::testWritesInfoDebugWithPsrLogger with data set #1 (Google\Cloud\Logging\LoggingClient Object (...))
Undefined offset: 100

./google-cloud-php/src/Logging/Connection/Grpc.php:315
./google-cloud-php/src/Logging/Connection/Grpc.php:125
./google-cloud-php/src/Logging/Logger.php:389
./google-cloud-php/src/Logging/Logger.php:358
./google-cloud-php/src/Logging/PsrLogger.php:491
./google-cloud-php/src/Logging/PsrLogger.php:390
./google-cloud-php/src/Logging/PsrLogger.php:272
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:237
./google-cloud-php/tests/system/Logging/WriteAndListEntryTest.php:221

[bshaffer]

Good catch, @jdpedrie. This is now fixed!

[dwsupplee]

Great find!

There is already a bit of logic touching on this - WDYT about modifying

https://github.com/GoogleCloudPlatform/google-cloud-php/blob/fa7977f7839b46a594cbef37a7d572127d10633b/src/Logging/Connection/Grpc.php#L314-L316

to

if (isset($entry['severity']) && is_string($entry['severity'])) {
    $entry['severity'] = array_flip(Logger::getLogLevelMap())[strtoupper($entry['severity'])];
}

and keeping the validate function from modifying the level?

[bshaffer]

@dwsupplee good call, that works way better.