-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Storage): support object retention lock #6829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we should test to check the case where we upload an object in locked retention mode and then try to change the retention:
- Decrease / Remove it => It should throw an exception from backend.
- Increase it => This should be possible.
Ref: User Guide (go/object-lock-user-guide)
I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Co-authored-by: Brent Shaffer <[email protected]>
Co-authored-by: Brent Shaffer <[email protected]>
Co-authored-by: Brent Shaffer <[email protected]>
This adds support for object retention lock
Fixes #6741
PRD: go/gcs-object-retention-client-request
Tests
System tests pass in my local which were run on an allowlisted project: