feat(Datastore): Enable SUM / AVG Aggregations #6817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
1) Implement logic 2) Refactor and implement unit testing for existing unit tests 3) Refactor and implement system testing for existing system tests Implement `NAN`, `INF`, `-INF` and `null` handling 1) Update entity mapper to parse requests and responses properly for rest as well as grpc 2) Implement unit testing to enusre this feature works properly a) At client level by mocking b) At entity mapper by invoking 3) Implement system testing to ensure proper insertions and lookup behaviour with NAN, null and +- INF's. Test corner cases for aggregations.
fix(Datastore): Fix `INF` and `NAN` handling in rest client nit fix Final fix for NAN, null and INF handling
php cs fix nit fix
yash30201
force-pushed
the
datastore-sum-avg
branch
from
8b27e03 to
06078a1
Compare
yash30201
added
type: feature request
* For @vishwarajanand's reviews
vishwarajanand
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements sum and average aggregations.
Design doc: go/php-datastore-sum-avg
Depends on #6811
Fixes #6808