Implement automatic downsizing of session pool #646
Conversation
googlebot
added
the
cla: yes
src/Spanner/Connection/Grpc.php
Outdated
| public function deleteSessionAsync(array $args) | ||
| { | ||
| $database = $this->pluck('database', $args); | ||
| $headerDescriptor = new AgentHeaderDescriptor([ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Spanner/V1/SpannerClient.php
Outdated
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| class SpannerClient extends SpannerGapicClient | ||
| { | ||
| // This class is intentionally empty, and is intended to hold manual additions to the generated {@see SpannerClientImpl} class. | ||
| /** | ||
| * Returns the underyling stub. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| foreach ($calls as $call) { | ||
| $call->wait(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -257,6 +268,11 @@ public function acquire($context = SessionPoolInterface::CONTEXT_READ) | |||
| $session = $this->waitForNextAvailableSession(); | |||
| } | |||
|
|
|||
| if ($this->deleteQueue) { | |||
| $this->deleteSessions($this->deleteQueue); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| // gRPC calls appear to cancel when the corresponding UnaryCall object | ||
| // goes out of scope. Keeping the calls in scope allows time for the | ||
| // calls to complete at the expense of a small memory footprint. | ||
| $this->deleteCalls = []; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
added
the
do not merge
dwsupplee
force-pushed
the
auto-downsize
branch
from
efc8c99 to
c68d5bf
Compare
dwsupplee
removed
the
do not merge
Closes: #490
Please note, the circumvention of the GAPIC client is intended to be temporary until concurrent request support is built into the clients.