feat(docs): add namespace (formatted for docfx) #6332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandhlee
reviewed
Jun 8, 2023
| @@ -10,6 +10,7 @@ items: | |||
|
|
|||
| This class is currently experimental and may be subject to changes. | |||
| type: class | |||
| namespace: 'Google \ Cloud \ SecretManager \ V1 \ Client' | |||
There was a problem hiding this comment.
Based on the example from googleapis/doc-pipeline#478, I think the namespace should have the SecretManagerServiceClient (maybe in href) added at the end - do you want to exclude the current class?
There was a problem hiding this comment.
I like the idea visually (as long as the href is wrapping it) but in this case, since this falls directly under the header Namespace, I think it would be confusing unless there's a way to make it VERY obvious. For instance, if we greyed it out and put it in italics.
There was a problem hiding this comment.
We also found that we can’t add HTML here so we are going to skip this for now (and hopefully add it later)
saranshdhingra
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for adding namespaces in #6321, and should look something like: