Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce flock/semaphore locking mechanisms #592

Merged
merged 3 commits into from
Jul 17, 2017
Merged

Introduce flock/semaphore locking mechanisms #592

merged 3 commits into from
Jul 17, 2017

Conversation

dwsupplee
Copy link
Contributor

Closes: #564

Included in this PR:

  • Flock based lock
  • Semaphore based lock
  • Updates to Spanner to remove references to symfony/lock
  • There were some useful methods in Google\Cloud\Core\Batch\SysvTrait that could be used outside of the context of batching, so it has been split out into two traits

@dwsupplee dwsupplee added api: spanner Issues related to the Spanner API. api: core labels Jul 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2017
jdpedrie
jdpedrie reviewed Jul 15, 2017
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

src/Core/Lock/LockTrait.php
* @return bool
* @throws \RuntimeException
*/
abstract public function acquire();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/Core/Lock/SemaphoreLock.php Outdated
throw new \InvalidArgumentException('The provided key must be an integer.');
}

if (!$this->isSysvIPCLoaded()) {

This comment was marked as spam.

Sign in to view

@dwsupplee dwsupplee merged commit 330b49e into googleapis:master Jul 17, 2017
@dwsupplee dwsupplee mentioned this pull request Jul 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: core api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @jdpedrie @googlebot