Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explore what this looks like here: https://michaelbausor.github.io/gcloud-php/#/docs/google-cloud/master/core/upload/streamableuploader
Points to note:
Existing problem that isn't fixed: we don't link correctly when the docs specify a relative class name. See e.g. the param documentation in the existing docs (Duration and Timestamp): https://googlecloudplatform.github.io/google-cloud-php/#/docs/google-cloud/v0.34.1/spanner/database?method=execute
I am not sure what we should do about this - maybe nothing in this PR, but think about a future fix? The easiest thing is to change our docs so that we use FQNs everywhere, but that is ugly for someone reading the code.