Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add / refactor dev commands #5861

Merged
merged 9 commits into from
Mar 28, 2023
Merged

chore: add / refactor dev commands #5861

merged 9 commits into from
Mar 28, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Feb 7, 2023

Big Changes

  • Adds a new script to add a component (dev/google-cloud add-component)
  • Adds a new script to list details of a component or all components (dev/google-cloud component-info)
  • Adds Component class for listing all details about a given component (used for docs, release script, and component info command)
  • Adds NewComponent class which determines expected names / paths for a new component based on the proto service file (used by new-component command).
  • Fixes release notes

Other refactorings!

  • Deleted manifest.json
  • Deleted the entire docs/ directory
  • Moved all dependencies used only for dev into dev/composer.json
  • Adds specific test workflow for dev which runs on 8.0 only
  • Refactors and simplifies old AddComponent command (uses twig, removes a lot of unnecessary logic)
  • Refactors github actions workflows for docs and lint into separate configuration files.
  • Removes old commands which are no longer used (Credentials command, ComponentIntegration command)

@bshaffer bshaffer force-pushed the fix-add-component branch from 787c1e9 to ef1af79 Compare March 1, 2023 15:11
@bshaffer bshaffer added the next release PRs to be included in the next release label Mar 1, 2023
@bshaffer bshaffer mentioned this pull request Mar 1, 2023
@bshaffer bshaffer removed the next release PRs to be included in the next release label Mar 8, 2023
@bshaffer bshaffer added the next release PRs to be included in the next release label Mar 20, 2023
@bshaffer bshaffer marked this pull request as ready for review March 20, 2023 23:05
@bshaffer bshaffer requested review from a team as code owners March 20, 2023 23:05
@bshaffer bshaffer force-pushed the fix-add-component branch from 696255b to 0d1f285 Compare March 21, 2023 14:40
@bshaffer bshaffer requested review from a team as code owners March 21, 2023 14:40
@snippet-bot
Copy link

snippet-bot bot commented Mar 21, 2023

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer force-pushed the fix-add-component branch 3 times, most recently from 3ddfa53 to c919e65 Compare March 21, 2023 14:45
@bshaffer bshaffer changed the title chore: update script which adds a new component chore: add / refactor dev commands Mar 21, 2023
dev/composer.json Outdated Show resolved Hide resolved
phpunit.xml.dist Outdated Show resolved Hide resolved
dev/sh/style Outdated Show resolved Hide resolved
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bshaffer bshaffer force-pushed the fix-add-component branch from b585449 to fb61d1e Compare March 25, 2023 15:06
@bshaffer bshaffer merged commit 343d5ac into main Mar 28, 2023
@bshaffer bshaffer deleted the fix-add-component branch March 28, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants