-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add / refactor dev commands #5861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
force-pushed
the
fix-add-component
branch
from
February 21, 2023 16:27
d11bef6
to
973db81
Compare
This was referenced Feb 21, 2023
bshaffer
force-pushed
the
fix-add-component
branch
from
March 1, 2023 15:11
787c1e9
to
ef1af79
Compare
bshaffer
force-pushed
the
fix-add-component
branch
from
March 21, 2023 14:40
696255b
to
0d1f285
Compare
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
bshaffer
force-pushed
the
fix-add-component
branch
3 times, most recently
from
March 21, 2023 14:45
3ddfa53
to
c919e65
Compare
bshaffer
changed the title
chore: update script which adds a new component
chore: add / refactor dev commands
Mar 21, 2023
vishwarajanand
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Co-authored-by: Vishwaraj Anand <[email protected]>
bshaffer
force-pushed
the
fix-add-component
branch
from
March 25, 2023 15:06
b585449
to
fb61d1e
Compare
noahdietz
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big Changes
dev/google-cloud add-component
)dev/google-cloud component-info
)Component
class for listing all details about a given component (used for docs, release script, and component info command)NewComponent
class which determines expected names / paths for a new component based on the proto service file (used bynew-component
command).Other refactorings!
manifest.json
docs/
directorydev
intodev/composer.json
dev
which runs on 8.0 onlyAddComponent
command (uses twig, removes a lot of unnecessary logic)docs
andlint
into separate configuration files.Credentials
command,ComponentIntegration
command)