Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of small documenting fixes for Spanner #579

Merged
merged 2 commits into from
Jul 13, 2017
Merged

A couple of small documenting fixes for Spanner #579

merged 2 commits into from
Jul 13, 2017

Conversation

RyanGordon
Copy link

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2017
@dwsupplee
Copy link
Contributor

👍 Thanks for these @RyanGordon

@RyanGordon
Copy link
Author

RyanGordon commented Jul 13, 2017 •
edited
Loading

No problem! Should this function not be returning something or is the comment wrong here? https://github.com/GoogleCloudPlatform/google-cloud-php/blob/master/src/Spanner/Session/Session.php#L119

@jdpedrie
Copy link
Contributor

jdpedrie commented Jul 13, 2017 •
edited
Loading

The request doesn't return anything, so the return here is superfluous, but doesn't hurt anything.

@dwsupplee dwsupplee merged commit 60c8277 into googleapis:master Jul 13, 2017
@RyanGordon RyanGordon deleted the doc_fix branch July 13, 2017 22:16
@dwsupplee dwsupplee mentioned this pull request Jul 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanGordon @dwsupplee @jdpedrie @googlebot